claudevdm commented on code in PR #35904:
URL: https://github.com/apache/beam/pull/35904#discussion_r2416960306
##########
sdks/python/apache_beam/internal/pickler_test.py:
##########
@@ -302,6 +318,18 @@ def test_disable_best_effort_determinism(self):
dumps(set1, enable_best_effort_determinism=False),
dumps(set2, enable_best_effort_determinism=False))
+ def test_enable_stable_code_identifier_pickling(self):
+ pickler.set_library('cloudpickle')
+ pickled = pickle_depickle(lambda x: x, True)
+ pickled_type = type(pickled)
+ self.assertIsInstance(pickled, pickled_type)
Review Comment:
Is there something else we can test/assert here specific to the behavior of
enable_stable_code_identifier_pickling? And in
test_disable_stable_code_identifier_pickling we can assert the opposite
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
