monicadsong commented on a change in pull request #12851:
URL: https://github.com/apache/beam/pull/12851#discussion_r489074298
##########
File path: sdks/python/apache_beam/transforms/stats_test.py
##########
@@ -89,6 +90,12 @@ def setUp(self):
None,
0.1,
'assert:global_by_error_with_large_population'),
+ (
+ 'numpy_input_data',
+ np.array(range(10)),
Review comment:
Ah sorry, just saw this. I didn't like the assumption I made about the
type of elements in the PCollection either, and the use case you mention is
definitely unsupported with this draft edit but would not alert the user if
they made that mistake.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
