liferoad commented on code in PR #36709:
URL: https://github.com/apache/beam/pull/36709#discussion_r2495598427
##########
sdks/python/apache_beam/typehints/native_type_compatibility.py:
##########
@@ -332,6 +338,14 @@ def convert_to_beam_type(typ):
sys.version_info.minor >= 10) and (isinstance(typ, types.UnionType)):
typ = typing.Union[typ]
+ # Unwrap Python 3.12 `type` aliases (TypeAliasType) to their underlying
value.
Review Comment:
Sounds good. Added one unit test `test_type_alias_type_unwrapped` in
sdks/python/apache_beam/typehints/native_type_compatibility_test.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
