praneetnadella commented on code in PR #36793: URL: https://github.com/apache/beam/pull/36793#discussion_r2525040887
########## sdks/python/apache_beam/internal/cloudpickle/cloudpickle.py: ########## @@ -1720,3 +1733,10 @@ def dumps( # Backward compat alias. CloudPickler = Pickler + + +def hash_dynamic_classdef(classdef): Review Comment: 1. The goal is to make this available for use and not called yet as an alternative to id_generator within CPConfig. 2. I feel like since we are using SHA-256 which is pretty collision-resistant, and because a single Beam pipeline will likely have a wide array of variability/complexity in class definitions, the odds are extremely low. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
