tvalentyn commented on code in PR #36793: URL: https://github.com/apache/beam/pull/36793#discussion_r2525039025
########## sdks/python/apache_beam/internal/cloudpickle/cloudpickle.py: ########## @@ -1720,3 +1733,10 @@ def dumps( # Backward compat alias. CloudPickler = Pickler + + +def hash_dynamic_classdef(classdef): Review Comment: i'd worry if the errors are silenced. Is detecting cheap? If so, that would help with a cleaner error message. Or if we believe this is really rare, we could add some comment in the codepath that will error-out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
