Abacn commented on code in PR #36809:
URL: https://github.com/apache/beam/pull/36809#discussion_r2535391424
##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineOptions.java:
##########
@@ -266,4 +267,30 @@ public String create(PipelineOptions options) {
List<String> getJdkAddOpenModules();
void setJdkAddOpenModules(List<String> options);
+
+ class AvroSerializableClassesFactory implements
DefaultValueFactory<List<String>> {
Review Comment:
I wonder if the default logic should be handled in boot.go. Technically
sdks/java/container/boot.go, the SDK harness binary isn't limited to Dataflow.
All portable runners use this container. Also in the case of Python/Yaml
pipeline Java SDK harness container spinned up without go through this
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineOptions.java
Consider the following, in boot.go,
```
if serializableClasses, ok :=
pipelineOptions.GetStructValue().GetFields()["avroSerializableClasses"]; ok &&
<serializableClasses not empty> {
...} else {
// default args
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
