clairemcginty commented on code in PR #36809:
URL: https://github.com/apache/beam/pull/36809#discussion_r2535583845
##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineOptions.java:
##########
@@ -266,4 +267,30 @@ public String create(PipelineOptions options) {
List<String> getJdkAddOpenModules();
void setJdkAddOpenModules(List<String> options);
+
+ class AvroSerializableClassesFactory implements
DefaultValueFactory<List<String>> {
Review Comment:
I guess the downside of that implementation is that if the user explicitly
sets `avroSerializableClasses` to an empty list (e.g. maybe they have a
security concern and want to disallow all java classes), it would be overridden
to the default args. I pushed a slightly different implementation that I think
would support an explicitly empty list (if pipeline option serialization works
the way I think it does 😅)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
