gemini-code-assist[bot] commented on code in PR #37014:
URL: https://github.com/apache/beam/pull/37014#discussion_r2593790929
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/DynamicDestinationsHelpers.java:
##########
@@ -279,11 +279,17 @@ static class
ConstantTimePartitioningClusteringDestinations<T>
private final @Nullable ValueProvider<String> jsonTimePartitioning;
private final @Nullable ValueProvider<String> jsonClustering;
+ // Lazily initialized and cached values.
+ private transient @Nullable String evaluatedPartitioning = null;
+ private transient @Nullable String evaluatedClustering = null;
+ private transient AtomicBoolean initialized = null;
Review Comment:
The `initialized` field is marked as `transient`. In Apache Beam, `DoFn`
instances and their member fields are frequently serialized and deserialized
(e.g., when moving between workers or during checkpointing). Marking
`initialized` as `transient` means its state will not be preserved across these
serialization boundaries. Upon deserialization, `initialized` will be `null`,
leading to a `NullPointerException` when `initialized.get()` is called. This
completely breaks the caching mechanism and can cause runtime errors.
```java
private @Nullable String evaluatedPartitioning = null;
private transient @Nullable String evaluatedClustering = null;
private AtomicBoolean initialized = null;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
