gemini-code-assist[bot] commented on PR #37133: URL: https://github.com/apache/beam/pull/37133#issuecomment-3666055460
## Summary of Changes Hello @Abacn, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request represents the initial phase of introducing Apache Flink 2 support into the project. It primarily focuses on foundational build system adjustments and a critical functional update. The build changes are designed to handle Flink 2's new requirements, such as a higher Java version and changes in its core APIs, by implementing flexible source overrides and conditional dependencies. Additionally, it ensures that the Flink portable runner respects the `getUseDataStreamForBatch` pipeline option, providing more control over execution strategies. ### Highlights * **Flink 2 Build System Refactoring**: Extensive refactoring of Gradle build scripts has been performed to prepare for Flink 2 support. This includes conditional Java 11 requirements for Flink 2, dynamic source directory overrides, and conditional dependency management to account for API changes like the removal of the DataSet API. * **Honoring getUseDataStreamForBatch Option**: The Flink portable runner now correctly honors the `getUseDataStreamForBatch` pipeline option, allowing users to explicitly choose the DataStream API for batch pipelines. * **Docker Image Naming Conventions**: Updated Docker image naming and tagging logic for Flink job server containers to accommodate Flink 2 specific conventions. * **Source File Restructuring**: Several Flink 1.17 specific source files have been moved to a more general location, indicating a restructuring to better support version-specific implementations and overrides for Flink 2. <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
