damccorm commented on code in PR #37133:
URL: https://github.com/apache/beam/pull/37133#discussion_r2666287584
##########
runners/flink/job-server-container/flink_job_server_container.gradle:
##########
@@ -53,15 +53,19 @@ task copyDockerfileDependencies(type: Copy) {
}
def pushContainers = project.rootProject.hasProperty(["isRelease"]) ||
project.rootProject.hasProperty("push-containers")
+def containerName = project.parent.name.startsWith("2") ? "flink_job_server" :
"flink${project.parent.name}_job_server"
Review Comment:
Why do we no longer need a separate container with flink 2?
##########
runners/flink/flink_runner.gradle:
##########
@@ -28,7 +28,8 @@ import groovy.json.JsonOutput
def base_path = ".."
def overrides(versions, type, base_path) {
- versions.collect { "${base_path}/${it}/src/${type}/java" } +
["./src/${type}/java"]
+ // order is important
Review Comment:
Why does order matter?
##########
runners/flink/job-server-container/flink_job_server_container.gradle:
##########
@@ -53,15 +53,19 @@ task copyDockerfileDependencies(type: Copy) {
}
def pushContainers = project.rootProject.hasProperty(["isRelease"]) ||
project.rootProject.hasProperty("push-containers")
+def containerName = project.parent.name.startsWith("2") ? "flink_job_server" :
"flink${project.parent.name}_job_server"
Review Comment:
Oh I see - you're moving to a tag approach. Maybe we could just do this
generally for all versions? It would be nice to not need a new container each
time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
