jiangzzhu commented on code in PR #36667:
URL: https://github.com/apache/beam/pull/36667#discussion_r2632893093
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIOReadChangeStreamTest.java:
##########
@@ -140,4 +150,53 @@ public void testWithDefaultCredential() {
assertEquals(defaultCredential,
changeStreamSpannerConfigWithCredential.getCredentials().get());
assertEquals(defaultCredential,
metadataSpannerConfigWithCredential.getCredentials().get());
}
+
+ @Test
+ public void testFetchPartitionModeGoogleSql() {
Review Comment:
can we parameterized the tests to have different combination among
googlesql/postgresql vs immuatable/mutable/empty string ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
