chenxuesdu commented on code in PR #36667:
URL: https://github.com/apache/beam/pull/36667#discussion_r2700258611
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIOReadChangeStreamTest.java:
##########
@@ -120,7 +129,8 @@ public void testSetSpannerConfigCredential() {
@Test
public void testWithDefaultCredential() {
- // Get the default credential, without setting any credentials in the
pipeline options or
+ // Get the default credential, without setting any credentials in the
pipeline
+ // options or
Review Comment:
Updated. Thanks.
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIOReadChangeStreamTest.java:
##########
@@ -140,4 +150,53 @@ public void testWithDefaultCredential() {
assertEquals(defaultCredential,
changeStreamSpannerConfigWithCredential.getCredentials().get());
assertEquals(defaultCredential,
metadataSpannerConfigWithCredential.getCredentials().get());
}
+
+ @Test
+ public void testFetchPartitionModeGoogleSql() {
+ DatabaseClient databaseClient = Mockito.mock(DatabaseClient.class);
Review Comment:
Refactored. Please take a look.
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIOReadChangeStreamTest.java:
##########
@@ -140,4 +150,53 @@ public void testWithDefaultCredential() {
assertEquals(defaultCredential,
changeStreamSpannerConfigWithCredential.getCredentials().get());
assertEquals(defaultCredential,
metadataSpannerConfigWithCredential.getCredentials().get());
}
+
+ @Test
+ public void testFetchPartitionModeGoogleSql() {
+ DatabaseClient databaseClient = Mockito.mock(DatabaseClient.class);
+ ReadOnlyTransaction transaction = Mockito.mock(ReadOnlyTransaction.class);
+ ResultSet resultSet = Mockito.mock(ResultSet.class);
+
+ when(databaseClient.readOnlyTransaction()).thenReturn(transaction);
+ when(transaction.executeQuery(any(Statement.class))).thenReturn(resultSet);
Review Comment:
Updated the test. please take a look.
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIOReadChangeStreamTest.java:
##########
@@ -140,4 +150,53 @@ public void testWithDefaultCredential() {
assertEquals(defaultCredential,
changeStreamSpannerConfigWithCredential.getCredentials().get());
assertEquals(defaultCredential,
metadataSpannerConfigWithCredential.getCredentials().get());
}
+
+ @Test
+ public void testFetchPartitionModeGoogleSql() {
Review Comment:
Will do it in a separate PR.
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIOReadChangeStreamTest.java:
##########
@@ -140,4 +150,53 @@ public void testWithDefaultCredential() {
assertEquals(defaultCredential,
changeStreamSpannerConfigWithCredential.getCredentials().get());
assertEquals(defaultCredential,
metadataSpannerConfigWithCredential.getCredentials().get());
}
+
+ @Test
+ public void testFetchPartitionModeGoogleSql() {
+ DatabaseClient databaseClient = Mockito.mock(DatabaseClient.class);
+ ReadOnlyTransaction transaction = Mockito.mock(ReadOnlyTransaction.class);
+ ResultSet resultSet = Mockito.mock(ResultSet.class);
+
+ when(databaseClient.readOnlyTransaction()).thenReturn(transaction);
+ when(transaction.executeQuery(any(Statement.class))).thenReturn(resultSet);
+ when(resultSet.next()).thenReturn(true).thenReturn(false);
+ when(resultSet.getString(0)).thenReturn("MUTABLE_KEY_RANGE");
+
+ assertEquals(
+ true,
+ SpannerIO.isMutableChangeStream(
+ databaseClient, Dialect.GOOGLE_STANDARD_SQL, TEST_CHANGE_STREAM));
+ }
+
+ @Test
+ public void testFetchPartitionModePostgres() {
+ DatabaseClient databaseClient = Mockito.mock(DatabaseClient.class);
+ ReadOnlyTransaction transaction = Mockito.mock(ReadOnlyTransaction.class);
+ ResultSet resultSet = Mockito.mock(ResultSet.class);
+
+ when(databaseClient.readOnlyTransaction()).thenReturn(transaction);
+ when(transaction.executeQuery(any(Statement.class))).thenReturn(resultSet);
+ when(resultSet.next()).thenReturn(true).thenReturn(false);
+ when(resultSet.getString(0)).thenReturn("IMMUTABLE_KEY_RANGE");
+
+ assertEquals(
+ false,
+ SpannerIO.isMutableChangeStream(databaseClient, Dialect.POSTGRESQL,
TEST_CHANGE_STREAM));
+ }
+
+ @Test
+ public void testFetchPartitionModeNotFound() {
+ DatabaseClient databaseClient = Mockito.mock(DatabaseClient.class);
+ ReadOnlyTransaction transaction = Mockito.mock(ReadOnlyTransaction.class);
+ ResultSet resultSet = Mockito.mock(ResultSet.class);
+
+ when(databaseClient.readOnlyTransaction()).thenReturn(transaction);
+ when(transaction.executeQuery(any(Statement.class))).thenReturn(resultSet);
+ when(resultSet.next()).thenReturn(false);
+
+ assertEquals(
+ false,
+ SpannerIO.isMutableChangeStream(
+ databaseClient, Dialect.GOOGLE_STANDARD_SQL, TEST_CHANGE_STREAM));
+ }
}
Review Comment:
Updated the test. Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
