gemini-code-assist[bot] commented on code in PR #37091:
URL: https://github.com/apache/beam/pull/37091#discussion_r2639739999
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/TableRowToStorageApiProto.java:
##########
@@ -199,6 +216,8 @@ public interface ThrowingBiFunction<FirstInputT,
SecondInputT, OutputT> {
static final DecimalFormat DECIMAL_FORMAT =
new DecimalFormat("0.0###############",
DecimalFormatSymbols.getInstance(Locale.ROOT));
+ private static final long PICOSECOND_PRECISION = 12L;
Review Comment:
The `PICOSECOND_PRECISION` constant is also defined as a private constant in
`BigQueryUtils.java`. To avoid this duplication and improve maintainability,
consider making the constant public in `BigQueryUtils` and reusing it here.
For example, you could change `BigQueryUtils.java` to have:
```java
public static final long PICOSECOND_PRECISION = 12L;
```
Then, you can remove the definition here and use
`BigQueryUtils.PICOSECOND_PRECISION` throughout this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
