gemini-code-assist[bot] commented on PR #37091: URL: https://github.com/apache/beam/pull/37091#issuecomment-3645077006
## Summary of Changes Hello @claudevdm, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances BigQueryIO by introducing full support for BigQuery TIMESTAMP columns with picosecond precision (12 fractional digits) when utilizing the BigQuery Storage Read API. The core objective is to prevent data loss for highly precise timestamp values by providing a mechanism for users to explicitly control the desired precision during data ingestion. This involves extending the BigQueryIO API with a new configuration option, updating internal data conversion and serialization logic for both Avro and Arrow formats, and ensuring that these changes are robustly tested through new unit and integration tests. ### Highlights * **Picosecond Timestamp Support**: BigQueryIO now supports reading and writing BigQuery TIMESTAMP columns with picosecond precision (12 fractional digits) when using the Storage Read API. This ensures that high-fidelity timestamp data can be accurately processed without loss of precision. * **New Configuration Option**: A new `withDirectReadPicosTimestampPrecision` method has been added to `BigQueryIO.TypedRead`, allowing users to explicitly specify the desired timestamp precision (MICROS, NANOS, or PICOS) for direct reads. * **Internal Data Handling Enhancements**: Internal utilities like `BigQueryUtils` and `TableRowToStorageApiProto` have been updated to correctly parse, represent, and serialize picosecond-precision timestamps. This includes a new `TimestampPicos` structure for internal representation and dynamic proto schema generation for 12-digit precision timestamps. * **Cross-Language Compatibility**: The `BigQueryIOReadTranslator` has been updated to ensure that the new timestamp precision setting is correctly propagated and translated in cross-language transforms, maintaining consistency across different Beam SDKs. * **Comprehensive Testing**: Extensive new unit and integration tests have been added to validate the correct handling of picosecond, nanosecond, and microsecond precision timestamps across both Avro and Arrow data formats, covering various read scenarios and ensuring data integrity. <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
