stankiewicz commented on code in PR #37164:
URL: https://github.com/apache/beam/pull/37164#discussion_r2640469027
##########
sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/read/UnboundedSolaceReader.java:
##########
@@ -150,9 +157,32 @@ public boolean advance() {
@Override
public void close() {
+ try {
+ if (nackCallback != null) {
+ // wait only for last one to finish, it will mean all the previous one
are also done.
+ nackCallback.get(ackDeadlineSeconds * 2, TimeUnit.SECONDS);
+ }
+ } catch (InterruptedException | ExecutionException | TimeoutException e) {
+ LOG.error("SolaceIO.Read: Failed to wait till nack background thread is
finished");
+ }
Review Comment:
not really, there are other background tasks that are scheduled on executor
service that I don't want to wait for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
