stankiewicz commented on code in PR #37164:
URL: https://github.com/apache/beam/pull/37164#discussion_r2682843009
##########
sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/SolaceIO.java:
##########
@@ -461,6 +462,7 @@ public static Read<Solace.Record> read() {
.setParseFn(SolaceRecordMapper::map)
.setTimestampFn(SENDER_TIMESTAMP_FUNCTION)
.setDeduplicateRecords(DEFAULT_DEDUPLICATE_RECORDS)
+ .setAckDeadlineSeconds(DEFAULT_ACK_DEADLINE_SECONDS)
Review Comment:
I really like the idea of measuring latency! At this moment I would keep it
as a configuration item where nack happen after 30s by default. After 60s
solace invalidates session. afair sessions were expensive in solace so they
have to be recycled quickly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
