chadrik commented on a change in pull request #12883:
URL: https://github.com/apache/beam/pull/12883#discussion_r491714764
##########
File path: sdks/python/apache_beam/metrics/metricbase.py
##########
@@ -78,7 +80,7 @@ def __hash__(self):
class Metric(object):
"""Base interface of a metric object."""
- pass
+ metric_name = None # type: MetricName
Review comment:
there seems to be an assumption that this attribute exists. should we
give this class an `__init__` that takes a `metric_name` argument?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
