chadrik commented on a change in pull request #12883:
URL: https://github.com/apache/beam/pull/12883#discussion_r495318636
##########
File path: sdks/python/apache_beam/metrics/metricbase.py
##########
@@ -78,7 +80,7 @@ def __hash__(self):
class Metric(object):
"""Base interface of a metric object."""
- pass
+ metric_name = None # type: MetricName
Review comment:
>I recommend adding init with a metric_name parameter to Metric and its
subclasses (Counter, Distribution and Gauge). This already exists on
DelegatingX classes, but could be done in the base Metric init instead.
Adding `metric_name` to `Metric.__init__` definitely seems like the best
solution to me, so I did that.
> If it were up to me we would remove Counter, Distribution and Gauge
classes and just have the DelegatingCounter DelegatingDistribution and
DelegatingGauge classes.
Leaving this for a future task.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
