nikitagrover19 commented on code in PR #37071: URL: https://github.com/apache/beam/pull/37071#discussion_r2681828049
########## sdks/python/apache_beam/typehints/row.py: ########## @@ -0,0 +1,76 @@ +# Review Comment: Thanks for pointing this out, that makes sense. I agree that row itself isn’t a typehint in the same way as RowTypeConstraint in row_type.py. After comparing this with other runtime value objects like Timestamp (which lives under apache_beam.utils), I can see that utils may be a more appropriate place for row as well. I initially placed it under typehints because of its close interaction with schema inference, but I understand the concern about semantics and structure. I’m happy to move row to apache_beam.utils and update the imports if that aligns better with beam’s conventions. please let me know what you’d prefer, i am still learning the codebase, so i really appreciate the guidance 🙂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
