jrmccluskey commented on code in PR #37248:
URL: https://github.com/apache/beam/pull/37248#discussion_r2682866616
##########
sdks/python/apache_beam/typehints/trivial_inference.py:
##########
@@ -512,6 +520,11 @@ def infer_return_type_func(f, input_types, debug=False,
depth=0):
# stack[-has_kwargs]: Map of keyword args.
# stack[-1 - has_kwargs]: Iterable of positional args.
# stack[-2 - has_kwargs]: Function to call.
+ if arg is None:
+ # CALL_FUNCTION_EX does not take an arg in 3.14, instead the
+ # signaling for kwargs is done via a PUSH_NULL instruction
+ # right before CALL_FUNCTION_EX.
+ arg = ~last_op_push_null & 1
Review Comment:
nevermind I was right, the gemini review was simply arguing over my comment
(which was unclear)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
