jrmccluskey commented on code in PR #37248:
URL: https://github.com/apache/beam/pull/37248#discussion_r2687568019
##########
sdks/python/apache_beam/typehints/native_type_compatibility.py:
##########
@@ -95,7 +95,7 @@ def _get_args(typ):
A tuple of args.
"""
try:
- if typ.__args__ is None:
+ if typ.__args__ is None or not isinstance(typ.__args__, tuple):
Review Comment:
If there are args they will be provided in a tuple. Pre-3.14, bare types
would have `None` as their __args__ attribute, but in 3.14 this case gets
treated as an internal-only empty member_attribute type that I can't explicitly
check for, so instead we check that the args attribute is not a tuple as a
backup check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
