tianz101 commented on code in PR #37326:
URL: https://github.com/apache/beam/pull/37326#discussion_r2710343613
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/action/QueryChangeStreamAction.java:
##########
@@ -179,10 +178,9 @@ public ProcessContinuation run(
final String token = partition.getPartitionToken();
final Timestamp startTimestamp = tracker.currentRestriction().getFrom();
final Timestamp endTimestamp = partition.getEndTimestamp();
Review Comment:
Here endTs from the partition can be
1) bounded (i.e., a specific end ts specified by user) or
2) unbounded(i.e., MAX_INCLUSIVE_END_AT).
If bounded,
1.1) For change stream V1, we can use the bounded endTs to query.
1.2) For change stream V2, we can not use the bounded endTs to query as
validation may fail endTs > max(startTs, now) + 30m and return exception. So we
should use now+2m instead.
If unbounded,
2.1) and 2.2) For both change stream V1 and V2 we have to use now+2m.
It seems we need V1 or V2 indicator to decide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
