jiangzzhu commented on code in PR #37326:
URL: https://github.com/apache/beam/pull/37326#discussion_r2714018801
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/action/QueryChangeStreamAction.java:
##########
@@ -250,6 +249,9 @@ public ProcessContinuation run(
tracker,
interrupter,
watermarkEstimator);
+ // The PartitionEndRecord indicates that there are no more records
expected
+ // for this partition.
+ stopAfterQuerySucceeds = true;
Review Comment:
Following on this comment, if we add stopAfterQuerySucceeds = true for both
ChildPartitionRecords and PartitionEndRecord, then we have assumption relying
on that spanner always returns both records in the end of partition. Should we
not make this assumption and rely on OutOfRange as the indicator of partition
end? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
