stankiewicz commented on code in PR #37012:
URL: https://github.com/apache/beam/pull/37012#discussion_r2769232865
##########
runners/core-java/src/main/java/org/apache/beam/runners/core/DoFnRunner.java:
##########
@@ -46,7 +46,8 @@ public interface DoFnRunner<InputT extends @Nullable Object,
OutputT extends @Nu
BoundedWindow window,
Instant timestamp,
Instant outputTimestamp,
- TimeDomain timeDomain);
+ TimeDomain timeDomain,
+ boolean causedByDrain);
Review Comment:
@kennknowles I'm curious your opinion. In timerdata I've introduced enum
CausedByDrain, should I move everywhere to enum then? it's not a lot of rework,
it's just many files modified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
