kennknowles commented on code in PR #37012:
URL: https://github.com/apache/beam/pull/37012#discussion_r2769816955
##########
runners/core-java/src/main/java/org/apache/beam/runners/core/DoFnRunner.java:
##########
@@ -46,7 +46,8 @@ public interface DoFnRunner<InputT extends @Nullable Object,
OutputT extends @Nu
BoundedWindow window,
Instant timestamp,
Instant outputTimestamp,
- TimeDomain timeDomain);
+ TimeDomain timeDomain,
+ boolean causedByDrain);
Review Comment:
Yes, enum is much clearer. Maybe an IDE can do it for you (even without AI
:-)
##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java:
##########
@@ -1929,6 +1938,11 @@ public <T> void outputWindowedValue(
}
outputTo(consumer, WindowedValues.of(output, timestamp, windows,
paneInfo));
}
+
+ @Override
+ public boolean causedByDrain() {
+ return currentElement.causedByDrain();
Review Comment:
Yes!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
