gemini-code-assist[bot] commented on PR #37632: URL: https://github.com/apache/beam/pull/37632#issuecomment-3917631738
## Summary of Changes Hello @mutianf, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Bigtable I/O connector by adding support for specifying row filters as a text proto string. This feature allows users to define complex row filters dynamically, particularly useful in templated pipelines where filter configurations might be provided as strings. The change introduces a new method `withRowFilterTextProto` in `BigtableIO.Read` and updates the underlying read options and parsing logic to handle this new filter type, ensuring compatibility and proper precedence with existing `RowFilter` options. ### Highlights * **New Row Filter Option**: Introduced `withRowFilterTextProto` to `BigtableIO.Read`, allowing users to specify Bigtable row filters as a `TextFormat` string via a `ValueProvider<String>`. This enables dynamic filter configuration, especially useful for templated pipelines. * **Filter Precedence**: If both `withRowFilter` (using a `RowFilter` object) and `withRowFilterTextProto` (using a text proto string) are provided, the existing `withRowFilter` takes precedence. * **Internal Handling**: The `BigtableReadOptions` now stores the `ValueProvider<String>` for the text proto filter, and the `BigtableIO.Read.Reader` class includes logic to parse this string into a `RowFilter` object when needed. * **Test Coverage**: A new test case, `testReadingWithRowFilterTextProto`, was added to `BigtableIOTest` to validate the functionality of reading rows using the new text proto filter option. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java** * Added `withRowFilterTextProto` method to `BigtableIO.Read` to accept a `ValueProvider<String>` for row filter text proto. * Modified `getRowFilter` logic to parse `rowFilterTextProto` if `rowFilter` is not set. * Imported `com.google.protobuf.TextFormat` and `checkNotNull`. * **sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableReadOptions.java** * Added `getRowFilterTextProto` abstract method to `BigtableReadOptions`. * Added `setRowFilterTextProto` to `BigtableReadOptions.Builder`. * Updated `populateDisplayData` to include `rowFilterTextProto`. * Added validation for `rowFilterTextProto`. * Imported `checkNotNull`. * **sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIOTest.java** * Added `testReadingWithRowFilterTextProto` to test the new functionality. </details> <details> <summary><b>Activity</b></summary> * The pull request was created by mutianf. * The pull request title indicates the intent to add an option for passing row filter text proto for Bigtable templates. * The pull request description contains a generic template, suggesting no specific human comments or detailed explanation from the author beyond the title. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
