igorbernstein2 commented on code in PR #37632:
URL: https://github.com/apache/beam/pull/37632#discussion_r2822273681
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java:
##########
@@ -1939,7 +1957,20 @@ public List<ByteKeyRange> getRanges() {
public @Nullable RowFilter getRowFilter() {
ValueProvider<RowFilter> rowFilter = readOptions.getRowFilter();
- return rowFilter != null && rowFilter.isAccessible() ? rowFilter.get() :
null;
+ if (rowFilter != null && rowFilter.isAccessible()) {
+ return rowFilter.get();
+ }
+
+ ValueProvider<String> rowFilterTextProto =
readOptions.getRowFilterTextProto();
+ if (rowFilterTextProto != null && rowFilterTextProto.isAccessible()) {
+ try {
Review Comment:
dont these need to chain together?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
