junaiddshaukat opened a new pull request, #37645:
URL: https://github.com/apache/beam/pull/37645
## Summary
Fixes #36592
Using Python 3.10+ pipe operator union types (e.g. `int | None`) in function
type hints causes `TypeError: issubclass() arg 1 must be a class` when Beam
performs type checking.
```
# This was crashing:
def func(x: int, y: int | None = None):
return x
with beam.Pipeline() as p:
(p | beam.Create([1]) | beam.Map(func))
# TypeError: issubclass() arg 1 must be a class
```
## Root Cause
The normalize() function in typehints.py did not handle types.UnionType
(Python 3.10+ pipe union syntax). On Python 3.10–3.13, int | None creates a
types.UnionType whose __module__ is not 'typing' and has no __origin__, so it
passed through normalize() unchanged. This caused is_consistent_with() to fall
through to issubclass() with a non-class argument.
## Fix
Added a types.UnionType check in normalize() that routes pipe union types
through convert_to_beam_type(), which already handles the conversion to Beam's
UnionConstraint.
## Tests Added
`test_hint_helper_pipe_union `— verifies `is_consistent_with()` works with
pipe union types
`test_normalize_pipe_union` — verifies `normalize()` converts
`types.UnionType` to `UnionConstraint`
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [X] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI or the [workflows
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md)
to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
