junaiddshaukat commented on PR #37645: URL: https://github.com/apache/beam/pull/37645#issuecomment-3926896890
cc @Abacn @liferoad — This PR fixes #36592 (type checking fails with Python `|` union syntax). As @Abacn noted, Beam has now dropped Python 3.9 support, so we can properly handle `types.UnionType`. The fix is a small addition to `normalize()` in `typehints.py` to route `types.UnionType` through `convert_to_beam_type()` which already knows how to convert it. The 5 failing checks are all unrelated (Milvus ML integration timeouts, Dataframes, YAML Xlang). Would appreciate a review when you get a chance. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
