arunpandianp commented on code in PR #37604:
URL: https://github.com/apache/beam/pull/37604#discussion_r2827076625
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingModeExecutionContext.java:
##########
@@ -832,17 +832,13 @@ public <W extends BoundedWindow> TimerData
getNextFiredTimer(Coder<W> windowCode
if (cachedFiredSystemTimers == null) {
cachedFiredSystemTimers =
FluentIterable.from(StreamingModeExecutionContext.this.getFiredTimers())
- .filter(
- timer ->
- WindmillTimerInternals.isSystemTimer(timer)
- && timer.getStateFamily().equals(stateFamily))
+ .filter(timer -> timer.getStateFamily().equals(stateFamily))
.transform(
timer ->
windmillTagEncoding.windmillTimerToTimerData(
- WindmillNamespacePrefix.SYSTEM_NAMESPACE_PREFIX,
- timer,
- windowCoder,
- getDrainMode()))
+ timer, windowCoder, getDrainMode()))
+ .filter(pair -> pair.getLeft() ==
WindmillTimerType.SYSTEM_TIMER)
Review Comment:
The windmillTimerType is computed by the transform, so we need to put the
filter after the transform.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
