arunpandianp commented on code in PR #37604:
URL: https://github.com/apache/beam/pull/37604#discussion_r2827081745
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/WindmillTimerType.java:
##########
@@ -20,27 +20,24 @@
import org.apache.beam.sdk.annotations.Internal;
import org.apache.beam.vendor.grpc.v1p69p0.com.google.protobuf.ByteString;
-/**
- * A prefix for a Windmill state or timer tag to separate user state and
timers from system state
- * and timers.
- */
+/** A type for a Windmill timer to separate user state and timers from system
state and timers. */
@Internal
-public enum WindmillNamespacePrefix {
- USER_NAMESPACE_PREFIX {
+public enum WindmillTimerType {
+ USER_TIMER {
@Override
- public ByteString byteString() {
+ public ByteString namespacePrefix() {
return USER_NAMESPACE_BYTESTRING;
}
},
- SYSTEM_NAMESPACE_PREFIX {
+ SYSTEM_TIMER {
@Override
- public ByteString byteString() {
+ public ByteString namespacePrefix() {
return SYSTEM_NAMESPACE_BYTESTRING;
}
};
- public abstract ByteString byteString();
+ public abstract ByteString namespacePrefix();
Review Comment:
good idea. Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
