gemini-code-assist[bot] commented on PR #37830: URL: https://github.com/apache/beam/pull/37830#issuecomment-4042094356
## Summary of Changes Hello, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a portable `Date` logical type to the Apache Beam model, standardizing the representation of date-only values across different SDKs. By defining a common URN and implementing the type in both Java and Python, it ensures consistent handling of dates without timezones, represented as the number of days since the epoch. This enhancement improves interoperability and simplifies schema management for date-related data. ### Highlights * **New Logical Type**: Introduced a new `DATE` logical type in the Beam schema definition (`schema.proto`), specifying its URN and `INT64` representation. * **Java SDK Implementation**: Implemented the `Date` logical type in the Java SDK, including its registration for schema translation and refinement of its argument handling. * **Python SDK Integration**: Updated the Python SDK to recognize and map `datetime.date` to the new `DATE` logical type URN, enhancing cross-language compatibility. * **Testing**: Added comprehensive unit tests in both Java and Python to validate the new `DATE` logical type's functionality and schema translation. * **Iceberg Integration Test Update**: Modified an Iceberg integration test to include `datetime` import, add a `date_` field to test data, and configure an `io-impl` property. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/schema.proto** * Added `DATE` enum value to `LogicalTypes.Enum` with its URN and description, specifying `INT64` as its representation type. * **sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/SchemaTranslation.java** * Imported `org.apache.beam.sdk.schemas.logicaltypes.Date`. * Registered the `Date.IDENTIFIER` with `Date.class` in the `LOGICAL_TYPE_IDENTIFIER_TO_CLASS` map. * **sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/logicaltypes/Date.java** * Added imports for `RunnerApi`, `SchemaApi`, and `Nullable`. * Updated the `IDENTIFIER` field to dynamically retrieve the URN from `SchemaApi.LogicalTypes.Enum.DATE`. * Modified `getArgumentType()` to return `null` and removed the `getArgument()` method, indicating no arguments for this logical type. * **sdks/java/core/src/test/java/org/apache/beam/sdk/schemas/SchemaTranslationTest.java** * Imported `java.time.LocalDate`. * Added a test schema entry for `Field.of("date", FieldType.logicalType(SqlTypes.DATE))`. * Included test data for the `DATE` logical type using `LocalDate.of(2000, 1, 3)`. * **sdks/python/apache_beam/portability/common_urns.py** * Added `date = LogicalTypes.Enum.DATE` to expose the new `DATE` URN. * **sdks/python/apache_beam/transforms/managed_iceberg_it_test.py** * Imported the `datetime` module. * Commented out the `@unittest.skipUnless` decorator for the `ManagedIcebergIT` class. * Added a `date_` field to the `_create_row` method, populating it with a calculated `datetime.date`. * Added `"io-impl": "org.apache.iceberg.gcp.gcs.GCSFileIO"` to `catalog_properties`. * **sdks/python/apache_beam/typehints/schemas.py** * Updated the schema mapping documentation to include `datetime.date <---> LogicalType(urn="beam:logical_type:date:v1")`. * Added a commented-out class `Date` which provides a Python implementation for the `Date` logical type, including `EPOCH` and conversion methods. * **sdks/python/apache_beam/typehints/schemas_test.py** * Imported the `datetime` module. * Added a `date: datetime.date` field to the `ComplexSchema` NamedTuple for testing purposes. </details> <details> <summary><b>Activity</b></summary> * No specific activity (comments, reviews, progress updates) was provided in the context. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
