Abacn commented on code in PR #37830:
URL: https://github.com/apache/beam/pull/37830#discussion_r3012175923
##########
sdks/python/apache_beam/io/jdbc.py:
##########
@@ -364,6 +361,9 @@ def __init__(
of the output PCollection elements. This bypasses automatic
schema inference during pipeline construction.
"""
+ # override new portable Date type with the current Jdbc type
+ # TODO: switch JdbcIO to return portable Date type
+ LogicalType.register_logical_type(JdbcDateType)
Review Comment:
If we need it again, we may want to put it into @contextlib.contextmanager
https://github.com/apache/beam/blob/476948856736da97ad41703ce5fd191d1c8e30d6/sdks/python/apache_beam/io/jdbc.py#L262
In fact we can add Date to the same try block here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
