arunpandianp commented on code in PR #37840:
URL: https://github.com/apache/beam/pull/37840#discussion_r2928643539
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##########
@@ -804,20 +808,54 @@ private static void
validateWorkerOptions(DataflowWorkerHarnessOptions options)
}
private static ChannelCache createChannelCache(
- DataflowWorkerHarnessOptions workerOptions, ComputationConfig.Fetcher
configFetcher) {
+ DataflowWorkerHarnessOptions workerOptions,
+ ComputationConfig.Fetcher configFetcher,
+ GrpcDispatcherClient dispatcherClient) {
ChannelCache channelCache =
- ChannelCache.create(
- (currentFlowControlSettings, serviceAddress) -> {
- // IsolationChannel will create and manage separate RPC channels
to the same
- // serviceAddress.
- return IsolationChannel.create(
- () ->
- remoteChannel(
- serviceAddress,
-
workerOptions.getWindmillServiceRpcChannelAliveTimeoutSec(),
- currentFlowControlSettings),
- currentFlowControlSettings.getOnReadyThresholdBytes());
- });
+ Boolean.TRUE.equals(
+ workerOptions
Review Comment:
We don't need to guard with the flag. The flag is defaulted to true and
removing it in https://github.com/apache/beam/pull/37844.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
