acrites commented on code in PR #37691:
URL: https://github.com/apache/beam/pull/37691#discussion_r2963121174
##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/MultimapUserState.java:
##########
@@ -93,14 +98,18 @@ public MultimapUserState(
this.beamFnStateClient = beamFnStateClient;
this.mapKeyCoder = mapKeyCoder;
this.valueCoder = valueCoder;
+ this.hasNoState = hasNoState;
+ this.onlyBundleForKeys = onlyBundleForKeys;
// Note: These StateRequest protos are constructed even if we never try to
read the
// corresponding state type. Consider constructing them lazily, as needed.
Review Comment:
This seems even more true now. We don't need `this.userStateRequest` or
`this.entryiesStateRequest` if `onlyBundleForKeys == true`. We could avoid
creating the Builders and assigning them in this case. It looks like we still
need `this.keysStateRequest` for now since it's used in a bunch of error logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
