LEEKYE commented on code in PR #37691:
URL: https://github.com/apache/beam/pull/37691#discussion_r2964207738
##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/MultimapUserState.java:
##########
@@ -93,14 +98,18 @@ public MultimapUserState(
this.beamFnStateClient = beamFnStateClient;
this.mapKeyCoder = mapKeyCoder;
this.valueCoder = valueCoder;
+ this.hasNoState = hasNoState;
+ this.onlyBundleForKeys = onlyBundleForKeys;
// Note: These StateRequest protos are constructed even if we never try to
read the
// corresponding state type. Consider constructing them lazily, as needed.
Review Comment:
There is a comment "Note: These StateRequest protos are constructed even if
we never try to read corresponding state type. Consider constructing them
lazily, as needed." So I believe it might be necessary to construct the state
requests for some reason even though they will not be used when hasNoState or
onlyBundleForKeys is true. Right now, the staterequests will not be sent when
hasNoState or onlyBundleForKeys is true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
