gemini-code-assist[bot] commented on PR #37954: URL: https://github.com/apache/beam/pull/37954#issuecomment-4130070333
## Summary of Changes Hello, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the handling of 'applied finalize IDs' within the Dataflow worker, particularly for streaming pipelines. It shifts the responsibility of carrying these IDs from a protobuf message to an internal Java class, `AssembledWorkItem`, and introduces a distinct step for queuing them. This modification ensures consistency between internal and external representations of work items, specifically by adding the `applied_finalize_ids` field to the `GetWorkResponse` proto, which is critical for the Appliance component and resolves issues preventing certain bundle finalizer tests from executing successfully. ### Highlights * **Refactoring of `applied_finalize_ids`**: The `applied_finalize_ids` field has been moved out of the `Windmill.WorkItem` proto and into the `AssembledWorkItem` class. This change addresses the absence of this field in the internal version of the `WorkItem` proto. * **Revised Finalization Process**: Instead of queuing finalize IDs directly within the `process()` call, they are now queued via a dedicated `queueAppliedFinalizeIds()` method, which is invoked separately before `scheduleWork()`. * **Proto Definition Update**: The `GetWorkResponse` proto has been updated to include `applied_finalize_ids`. This field, which already existed internally, is now exposed externally, ensuring compatibility with Appliance and enabling relevant runner tests to pass. * **Enabled Bundle Finalizer Tests**: The exclusion of `UsesBundleFinalizer` tests for streaming appliance in the `build.gradle` file has been removed, indicating that these tests are now expected to pass with the implemented changes. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
