jrmccluskey commented on code in PR #37954:
URL: https://github.com/apache/beam/pull/37954#discussion_r2995403196
##########
runners/google-cloud-dataflow-java/worker/windmill/src/main/proto/windmill.proto:
##########
@@ -448,8 +448,6 @@ message WorkItem {
// present, this field includes metadata associated with any hot key.
optional HotKeyInfo hot_key_info = 11;
- repeated int64 applied_finalize_ids = 16;
Review Comment:
this is best practice for protos anyway, field numbers should never be
re-used even if the field is deprecated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
