derrickaw commented on code in PR #38090:
URL: https://github.com/apache/beam/pull/38090#discussion_r3052806049
##########
sdks/python/setup.py:
##########
@@ -167,23 +162,39 @@ def cythonize(*args, **kwargs):
milvus_dependency = ['pymilvus>=2.5.10,<3.0.0']
-ml_base = [
+# google-adk / OpenTelemetry require protobuf>=5; tensorflow-transform in
+# ml_test is pinned to versions that require protobuf<5 on Python 3.10. Those
+# cannot be installed together, so ADK deps stay out of ml_test (use ml_base).
+ml_base_core = [
'embeddings>=0.0.4', # 0.0.3 crashes setuptools
- 'google-adk',
'onnxruntime',
+ # onnx 1.12–1.13 cap protobuf in ways that trigger huge backtracking with
+ # Beam[gcp]+ml_test; pip can fall back to onnx 1.11 sdist which needs
cmake.
+ # 1.14.1+ matches tf2onnx>=1.16 and ships manylinux wheels for py3.10.
+ 'onnx>=1.14.1,<2',
'langchain',
'sentence-transformers>=2.2.2',
'skl2onnx',
- 'pyod>=0.7.6', # 0.7.5 crashes setuptools
+ 'pyod>=0.7.6', # 0.7.5 crashes setuptools
'tensorflow',
# tensorflow transitive dep, lower versions not compatible with Python3.10+
'absl-py>=0.12.0',
'tensorflow-hub',
- 'tf2onnx',
'torch',
'transformers',
]
+ml_adk_dependency = [
+ 'google-adk==1.17.0',
Review Comment:
can we go to 1.28.1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
