aIbrahiim commented on code in PR #38090: URL: https://github.com/apache/beam/pull/38090#discussion_r3053222633
########## sdks/python/setup.py: ########## @@ -167,23 +162,39 @@ def cythonize(*args, **kwargs): milvus_dependency = ['pymilvus>=2.5.10,<3.0.0'] -ml_base = [ +# google-adk / OpenTelemetry require protobuf>=5; tensorflow-transform in +# ml_test is pinned to versions that require protobuf<5 on Python 3.10. Those Review Comment: yes ml_test is the TFT/protobuf<5 path on purpose and ADK still gets installed and exercised via ml_base / p310_ml_test / p312_ml_test / p313_ml_test (whatever CI/tox runs with the full ML stack). YAML/Xlang uses ml_test,yaml and doesnt need ADK in that venv for what those jobs cover -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
