dejii commented on code in PR #38149:
URL: https://github.com/apache/beam/pull/38149#discussion_r3075587971
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/AppendFilesToTables.java:
##########
@@ -251,5 +252,12 @@ private boolean shouldSkip(Table table,
Iterable<FileWriteResult> fileWriteResul
}
return false;
}
+
+ @Teardown
+ public void teardown() throws IOException {
+ if (catalog instanceof Closeable) {
+ ((Closeable) catalog).close();
Review Comment:
What do you think is the way forward here? The current state i.e., closing
`FileIO` in `@FinishBundle` via `RecordWriterManager.close()` is worse. Should
we move catalog initialization to `@Setup` and close it in `@Teardown`? That
would make the lifecycle explicit and address the `IcebergCatalogConfig`
sharing concern for the "passed as instance" case as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
