stankiewicz commented on code in PR #38149:
URL: https://github.com/apache/beam/pull/38149#discussion_r3075675155
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/AppendFilesToTables.java:
##########
@@ -251,5 +252,12 @@ private boolean shouldSkip(Table table,
Iterable<FileWriteResult> fileWriteResul
}
return false;
}
+
+ @Teardown
+ public void teardown() throws IOException {
+ if (catalog instanceof Closeable) {
+ ((Closeable) catalog).close();
Review Comment:
on closing, I guess this PR has one of the valid approaches, with the
assumption that catalog is unique to doFn instance.
One problem - RecordWriterManager still have static cache where
`getOrCreateTable` may return closed IO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
