tianz101 commented on code in PR #38167:
URL: https://github.com/apache/beam/pull/38167#discussion_r3076143708
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/dao/ChangeStreamDao.java:
##########
@@ -117,16 +124,29 @@ public ChangeStreamResultSet changeStreamQuery(
.to(heartbeatMillis)
.build();
} else {
- query =
- "SELECT * FROM READ_"
- + changeStreamName
- + "("
- + " start_timestamp => @startTimestamp,"
- + " end_timestamp => @endTimestamp,"
- + " partition_token => @partitionToken,"
- + " read_options => null,"
- + " heartbeat_milliseconds => @heartbeatMillis"
- + ")";
+ if (this.isMutableChangeStream && tvfName != null &&
!tvfName.equals(DEFAULT_TVF_NAME)) {
+ query =
+ "SELECT * FROM "
+ + tvfName
Review Comment:
When the code reaches here, the tvfName has been validated already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
