tianz101 commented on code in PR #38167:
URL: https://github.com/apache/beam/pull/38167#discussion_r3127527588
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/dao/PartitionMetadataDao.java:
##########
@@ -132,14 +134,41 @@ public List<String> findAllTableIndexes() {
return result;
}
+ public static String escapeTvfName(String tvfName) {
+ return tvfName.replace("'", "").replace("\"", "");
+ }
Review Comment:
The TVF name itself will not contain quotes, but users may qute the tvf name
with various quotes. We need to escape them and validate the tvf name itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
