shunping commented on code in PR #38342:
URL: https://github.com/apache/beam/pull/38342#discussion_r3169518479


##########
sdks/python/container/boot.go:
##########
@@ -408,6 +412,10 @@ func installSetupPackages(ctx context.Context, logger 
*tools.Logger, files []str
        bufLogger := tools.NewBufferedLogger(logger)
        bufLogger.Printf(ctx, "Installing setup packages ...")
 
+       if err := logRuntimeDependencies(ctx, bufLogger, "pre-installation"); 
err != nil {

Review Comment:
   While we already log dependencies after installation, `boot.go` exits 
immediately if any installation step fails. 
   
   Adding a pre-installation call ensures we capture the environment state 
regardless of whether the installation succeeds. This is useful for reproducing 
and triaging environment-specific failures from customers.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to