tvalentyn commented on code in PR #38342:
URL: https://github.com/apache/beam/pull/38342#discussion_r3169621463


##########
sdks/python/container/boot.go:
##########
@@ -408,6 +412,10 @@ func installSetupPackages(ctx context.Context, logger 
*tools.Logger, files []str
        bufLogger := tools.NewBufferedLogger(logger)
        bufLogger.Printf(ctx, "Installing setup packages ...")
 
+       if err := logRuntimeDependencies(ctx, bufLogger, "pre-installation"); 
err != nil {

Review Comment:
   'pre-installation', 'post-installation' sounds a bit cryptic for end user 
who is not a beam dev, and the output may be a a bit verbose.
   
   How about we think of a way to enable debug logging for boot.go and only 
print pre-installation env if debug logging is enabled? then, we can ask 
affected customers to run their pipeline with debug logging enabled if 
necessary.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to