tkaymak commented on code in PR #38453:
URL: https://github.com/apache/beam/pull/38453#discussion_r3225387927
##########
.github/workflows/beam_PreCommit_Java_Spark_Versions.yml:
##########
@@ -87,12 +87,17 @@ jobs:
github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
- name: Setup environment
uses: ./.github/actions/setup-environment-action
+ with:
+ java-version: |
+ 17
+ 11
- name: run sparkVersionsTest script
uses: ./.github/actions/gradle-command-self-hosted-action
with:
- gradle-command: :runners:spark:3:sparkVersionsTest
+ gradle-command: :runners:spark:3:sparkVersionsTest
:runners:spark:4:build
Review Comment:
Confirms the `requireJavaVersion=17` plumbing from #38324 plus the new
`forkJavaVersion` → `testJavaVersion` fallback in this PR will make
`:runners:spark:4:build` fork to JDK 17 for both compile and test on a
Java-11-default CI box. With `actions/setup-java`'s multi-line `java-version`
putting `JAVA_HOME` on the last-listed entry, Spark 3 keeps its primary JDK and
Spark 4 forks via `-Pjava17Home=$JAVA_HOME_17_X64`. Clean.
##########
.github/workflows/beam_PreCommit_Java_Spark_Versions.yml:
##########
@@ -87,12 +87,17 @@ jobs:
github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
- name: Setup environment
uses: ./.github/actions/setup-environment-action
+ with:
+ java-version: |
+ 17
+ 11
- name: run sparkVersionsTest script
uses: ./.github/actions/gradle-command-self-hosted-action
with:
- gradle-command: :runners:spark:3:sparkVersionsTest
+ gradle-command: :runners:spark:3:sparkVersionsTest
:runners:spark:4:build
Review Comment:
Confirms the `requireJavaVersion=17` plumbing from #38324 plus the new
`forkJavaVersion` → `testJavaVersion` fallback in this PR will make
`:runners:spark:4:build` fork to JDK 17 for both compile and test on a
Java-11-default CI box. With `actions/setup-java`'s multi-line `java-version`
putting `JAVA_HOME` on the last-listed entry, Spark 3 keeps its primary JDK and
Spark 4 forks via `-Pjava17Home=$JAVA_HOME_17_X64`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
