tkaymak commented on code in PR #38453:
URL: https://github.com/apache/beam/pull/38453#discussion_r3225387943
##########
.github/workflows/beam_PreCommit_Java_Spark_Versions.yml:
##########
@@ -15,21 +15,21 @@
# specific language governing permissions and limitations
# under the License.
-name: PreCommit Java Spark3 Versions
+name: PreCommit Java Spark Versions
on:
push:
tags: ['v*']
branches: ['master', 'release-*']
paths:
- 'runners/spark/**'
- - '.github/workflows/beam_PreCommit_Java_Spark3_Versions.yml'
+ - '.github/workflows/beam_PreCommit_Java_Spark_Versions.yml'
pull_request_target:
branches: ['master', 'release-*']
paths:
- 'runners/spark/**'
- 'release/trigger_all_tests.json'
- - '.github/trigger_files/beam_PreCommit_Java_Spark3_Versions.json'
+ - '.github/trigger_files/beam_PreCommit_Java_Spark_Versions.json'
Review Comment:
Two trigger-file follow-ups I'm happy to roll into the small cleanup PR I'm
already drafting for #38255:
1. The renamed workflow references
`.github/trigger_files/beam_PreCommit_Java_Spark_Versions.json` here, but no
file with that name exists it might be worth adding a stub for symmetry with
the other workflows that use this mechanism, otherwise the
`pull_request_target.paths` trigger is a no-op for that path.
2. The orphaned
`.github/trigger_files/beam_PreCommit_Java_Spark4_Versions.json` (left over
after #38255 deleted its workflow) is still on master and should be cleaned up
too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
