gemini-code-assist[bot] commented on code in PR #38472:
URL: https://github.com/apache/beam/pull/38472#discussion_r3228121779
##########
sdks/python/apache_beam/runners/portability/prism_runner_test.py:
##########
@@ -457,6 +458,29 @@ def test_with_remote_path(self, has_cache_bin,
has_cache_zip, ignore_cache):
mock_zipfile_init.assert_called_once()
+class PrismRunnerExecutionTest(unittest.TestCase):
+ def test_dofn_failure_clean_exit(self):
+ class FailDoFn(beam.DoFn):
+ def process(self, element):
+ raise ValueError("Failing as intended")
+
+ class BlockDoFn(beam.DoFn):
+ def process(self, element):
+ time.sleep(10)
+ yield element
+
+ from apache_beam.options.pipeline_options import PrismRunnerOptions
Review Comment:
The import `PrismRunnerOptions` is unused in this test. Based on the
subsequent lines (473-474), it appears you intended to import `PortableOptions`
and `StandardOptions` instead. Without these imports, the test will likely fail
with a `NameError` when attempting to instantiate `PortableOptions()`.
```suggestion
from apache_beam.options.pipeline_options import PortableOptions,
StandardOptions
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
