piotr-szuberski commented on a change in pull request #12827:
URL: https://github.com/apache/beam/pull/12827#discussion_r494841227
##########
File path:
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/kafka/BeamKafkaTableTest.java
##########
@@ -184,24 +185,11 @@ private static Schema genSchema() {
.build());
}
- private static class String2KvBytes extends DoFn<String, KV<byte[], byte[]>>
+ protected static class String2KvBytes extends DoFn<String, KV<byte[],
byte[]>>
Review comment:
It will also be used in JSON table provider, that's why it's here as
protected. But I can move it in the json PR in order to keep this one more
consistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
